Fix randint TypeError in video tutorial by casting frame count to int #2396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In frames_from_video_file, cv2.VideoCapture().get(cv2.CAP_PROP_FRAME_COUNT) returns a float. This causes random.randint to fail with: TypeError: 'float' object cannot be interpreted as an integer Fix: cast (video_length - need_length) to int before passing to randint.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
PreviewPreview and run these notebook edits with Google Colab: Rendered notebook diffs available on ReviewNB.com.Format and styleUse the TensorFlow docs notebook tools to format for consistent source diffs and lint for style:$ python3 -m pip install -U --user git+https://github.com/tensorflow/docsIf commits are added to the pull request, synchronize your local branch: git pull origin fix/video-tutorial-randint
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In
frames_from_video_file(insidesite/en/tutorials/load_data/video.ipynb), the code fails when running:with the following error:
This happens because:
cv2.VideoCapture().get(cv2.CAP_PROP_FRAME_COUNT) returns a float.
As a result, max_start is a float, and random.randint requires integers.
Fix
Cast max_start to int:
Result
The function now works correctly, and the tutorial executes without raising TypeError.